Misc icon tweaks, relax lint rules by silverwind · Pull Request #36046 · go-gitea/gitea

silverwind · 2025-11-27T23:54:44Z

~~Use octicon-repo-locked to indicate private repos, also visible on the repo header now~~
~~Use octicon-repo-forked to indicate forked repos~~
Fix pull icons on pulse page
Remove "gold" color from private icons, we have been removing this color on frontpage repolist, so now the rest of the UI is also consistent. Also remove the now-unused gold color.

silverwind · 2025-11-28T17:14:58Z

Regarding octicon-repo-locked: I'm not sure it's actually right. I checked GH and they do not use it for the purpose of private repos at all. All they do is show a octicon-lock besides repo names in some places. So I think I will revert this change.

silverwind · 2025-11-28T17:35:52Z

Regarding octicon-repo-locked: I'm not sure it's actually right. I checked GH and they do not use it for the purpose of private repos at all. All they do is show a octicon-lock besides repo names in some places. So I think I will revert this change.

Maybe this icon is actually fine. I think a repo book icon with a padlock is better than a padlock only. We do not have a "locked" state yet for repos, so this icon is unambiguous too.

silverwind · 2025-11-28T17:40:49Z

One more minor change, ShowRepoAvatar is now enabled in repo lists, meaning they will render the repo avatar. This affects at least the explore repo list and org repo list.

lunny · 2025-11-28T19:03:37Z

A repository can fall into several state groups:

Group 1: IsMirror, IsFork, IsRegular
Group 2: IsTemplate
Group 3: Public, Private

We can add icons for the states in Group 1, and use text labels for the other groups to maintain consistency and avoid visual conflicts.

silverwind · 2025-11-28T20:02:03Z

Sounds like a plan, I will try that.

silverwind · 2025-12-04T20:49:07Z

Applied that logic, so there is only 3 states of the repo icon now.

Also, I disabled lint rules that forbid "else-return" constructs. I find those just annoying because they forbid code like this and fixing it breaks the symmetry of the block which looks ugly.

  } else {
    return 'octicon-repo';
  }

Signed-off-by: silverwind <me@silverwind.io>

silverwind · 2025-12-04T20:54:58Z

Ready now, I think it's a good cleanup and now all repo icons are the same everywhere.

lunny · 2025-12-05T01:51:19Z

-										{{else}}
-											<span class="icon">{{svg "octicon-repo"}}</span>
-										{{end}}
+										{{template "repo/icon" (dict "Repo" $repo "Size" 16)}}


It's better to have labels(private, template & etc.) for this repository

You mean adding labels in this specific place (and below)?

I mean, it appears that the labels are only shown on the repository detail page. They could also be displayed on the list page, but I’m not sure whether we should enable that.

In lists we can add them, yes.

lunny · 2025-12-05T01:51:49Z

-									{{else}}
-										{{svg "octicon-repo"}}
-									{{end}}
+									{{template "repo/icon" (dict "Repo" . "Size" 16)}}


Same as the above

wxiaoguang · 2025-12-05T18:46:02Z

-										{{else if $repo.IsMirror}}
-											<span class="icon">{{svg "octicon-mirror"}}</span>
-										{{else if $repo.IsTemplate}}
-											<span class="icon">{{svg "octicon-repo-template"}}</span>


IsTemplate is missing in icon.tmpl

If intentionally, should the comment #36046 (comment) be added to the template code? ps: I don't understand why IsTemplate is in a separate "group".

Both mirror repositories and regular repositories(public or private) could be template repositories.

If intentionally, should the comment #36046 (comment) be added to the template code? ps: I don't understand why IsTemplate is in a separate "group".

If intentionally, should the comment #36046 (comment) be added to the template code?

I can add it. And yes I've implemented that only group 1 is represented with the icon, all other groups are represented with tags in places that have enough room to display them (not on frontpage repo list).

Thought maybe we should make an exception for templates. I think it's highly unlikely that a repo is both a mirror and a template, so I guess showing a template icon in such a case would make more sense.

Copilot

Pull request overview

This pull request improves icon consistency across the Gitea UI and removes the deprecated "gold" color styling for private repositories and organizations. The changes consolidate repository icon logic into a reusable utility function and fix semantically incorrect icon usage.

Changes:

Fixed pull request icons on the pulse page (using octicon-git-merge for merged PRs and octicon-git-pull-request for open PRs)
Removed gold color styling from private repo/org indicators throughout admin and user settings templates
Consolidated repo icon logic into a new getRepoIcon utility function with corresponding template refactoring
Relaxed lint rules (no-else-return in ESLint and indent-error-flow in golangci) to accommodate clearer code patterns

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
web_src/js/utils/mappings.ts	New utility function `getRepoIcon` to centralize repo icon logic
web_src/js/components/DashboardRepoList.vue	Refactored to use new `getRepoIcon` utility, removing duplicate icon selection logic
web_src/css/themes/theme-gitea-light.css	Removed `--color-gold` CSS variable
web_src/css/themes/theme-gitea-dark.css	Removed `--color-gold` CSS variable
web_src/css/base.css	Removed `.text.gold` class definition
templates/user/settings/repos.tmpl	Replaced inline icon logic with `repo/icon` template calls
templates/shared/repo/list.tmpl	Updated to use `repo/icon` template; fixed fork count icon from `octicon-git-branch` to `octicon-repo-forked`
templates/repo/pulse.tmpl	Fixed PR icons: `octicon-git-merge` for merged, `octicon-git-pull-request` for proposed
templates/repo/icon.tmpl	Refactored to accept dict parameters (Repo, Size, ShowRepoAvatar, ShowRepoOwnerAvatar)
templates/repo/header.tmpl	Updated to use new `repo/icon` template syntax with dict params
templates/org/team/repositories.tmpl	Updated to use new `repo/icon` template syntax with dict params
templates/admin/repo/list.tmpl	Removed gold color class from private owner indicators
templates/admin/packages/list.tmpl	Removed gold color class from private owner indicators
templates/admin/org/list.tmpl	Removed gold color class from private org indicators
eslint.config.ts	Relaxed `no-else-return` rule to allow clearer code patterns
.golangci.yml	Removed `indent-error-flow` rule to allow more flexible error handling patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silverwind <me@silverwind.io>

wxiaoguang · 2026-02-13T00:05:31Z

No idea why "experienced" programmers never wrote comments, just keep making others guess.

Misc icon tweaks

c982031

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2025

github-actions Bot added modifies/templates labels Nov 27, 2025

delvh approved these changes Nov 28, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2025

lunny reviewed Nov 28, 2025

View reviewed changes

Comment thread templates/repo/icon.tmpl Outdated

lunny reviewed Nov 28, 2025

View reviewed changes

Comment thread templates/user/settings/repos.tmpl Outdated

silverwind added 2 commits November 28, 2025 17:05

Merge branch 'main' into icons

a7e54b7

improve repo/icon template, extract js function

092b7fd

github-actions Bot added the modifies/go label Nov 28, 2025

fixes

11ed040

github-actions Bot removed the modifies/go label Nov 28, 2025

sync order between js and template

fd0d451

enable ShowRepoAvatar on repo lists

ef1a146

silverwind marked this pull request as draft December 1, 2025 13:24

silverwind added 2 commits December 4, 2025 21:39

Merge branch 'main' into icons

80e06d2

apply suggestions, disable annoying lint rules

45c1769

github-actions Bot added topic/code-linting modifies/internal labels Dec 4, 2025

silverwind changed the title ~~Misc icon tweaks~~ Misc icon tweaks, relax lint rules Dec 4, 2025

silverwind commented Dec 4, 2025

View reviewed changes

Comment thread web_src/js/components/DashboardRepoList.vue Outdated

Revert icon

5d1676d

Signed-off-by: silverwind <me@silverwind.io>

silverwind added 2 commits December 4, 2025 21:52

remove unused

b2db8c0

comment

5625d99

silverwind marked this pull request as ready for review December 4, 2025 20:54

silverwind added 6 commits December 4, 2025 21:56

remove size default as we specify it everywhere

a2cf45d

remove whitespace

180e482

remove empty alt attribute

60790fe

fix size

038b4e2

restore alt, it has a purpose

efdc304

improve template docs

fd5cc7d

lunny reviewed Dec 5, 2025

View reviewed changes

lunny approved these changes Dec 5, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2025

wxiaoguang reviewed Dec 5, 2025

View reviewed changes

wxiaoguang marked this pull request as draft December 12, 2025 03:06

silverwind added 2 commits December 18, 2025 00:20

Merge branch 'main' into icons

78dd82a

Merge branch 'main' into icons

7210003

silverwind requested a review from Copilot February 12, 2026 18:37

Copilot started reviewing on behalf of silverwind February 12, 2026 18:41 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Comment thread templates/repo/icon.tmpl Outdated

Update templates/repo/icon.tmpl

d08a4bf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silverwind <me@silverwind.io>

lunny removed modifies/templates labels Apr 19, 2026

Uh oh!

Conversation

silverwind commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Nov 28, 2025

Uh oh!

silverwind commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Nov 28, 2025

Uh oh!

lunny commented Nov 28, 2025

Uh oh!

silverwind commented Nov 28, 2025

Uh oh!

silverwind commented Dec 4, 2025

Uh oh!

Uh oh!

silverwind commented Dec 4, 2025

Uh oh!

lunny Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

lunny Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

lunny Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lunny Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

wxiaoguang commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind commented Nov 27, 2025 •

edited

Loading

silverwind commented Nov 28, 2025 •

edited

Loading

wxiaoguang Dec 5, 2025 •

edited

Loading

lunny Dec 5, 2025 •

edited

Loading

silverwind Dec 6, 2025 •

edited

Loading